Closed
Conversation
nodejs-github-bot
added
the
build
Contributor
Author
vsemozhetbyt
added
doc
maclover7
approved these changes
Aug 14, 2018
lpinca
approved these changes
Aug 14, 2018
jasnell
approved these changes
Aug 14, 2018
richardlau
approved these changes
Aug 14, 2018
maclover7
added
the
author ready
This commit adds the test-doc target to the test recipe so that docs are built and linters run. This used to happen but was removed at some point.
danbev
force-pushed
the
build_add_back_lint
branch
from
5c7e05a to
c8d6e3b
Compare
Contributor
Author
Contributor
Author
|
Re-run of failing node-test-commit-windows-fanned which is green. |
Contributor
Author
|
Landed in 95b0e2c. |
danbev
added a commit
that referenced
this pull request
Aug 20, 2018
This commit adds the test-doc target to the test recipe so that docs are built and linters run. This used to happen but was removed at some point. PR-URL: #22294 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Aug 21, 2018
This commit adds the test-doc target to the test recipe so that docs are built and linters run. This used to happen but was removed at some point. PR-URL: #22294 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
This commit adds the test-doc target to the test recipe so that docs are built and linters run. This used to happen but was removed at some point. PR-URL: #22294 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the test-doc target to the test recipe so that docs are
built and linters run. This used to happen but was removed at some
point.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes